Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10700#discussion_r49654293
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1681,6 +1681,9 @@ class SparkContext(config: SparkConf) extends Logging
with ExecutorAllocationCli
Utils.tryLogNonFatalError {
_executorAllocationManager.foreach(_.stop())
}
+ Utils.tryLogNonFatalError {
--- End diff --
Maybe add a comment here to explain why this needs to be stopped before the
DAGScheduler in order to prevent this change from being accidentally lost in
the future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
