Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10604#discussion_r49661255
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -683,9 +685,29 @@ abstract class HadoopFsRelation private[sql](
}
}
- buildInternalScan(requiredColumns, filters, inputStatuses,
broadcastedConf)
+ if (bucketSpec.isDefined && sqlContext.conf.bucketingEnabled()) {
+ val inputFilesWithBucketId = allInputFiles.groupBy(getBucketId)
--- End diff --
I'm still concerned about perf here. This should be O(number of files) and
not O(number of files, number of buckets). Getting metadata related things are
slow enough as is when the number of files is large.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
