Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10735#discussion_r49666729
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
    @@ -106,7 +106,27 @@ abstract class SparkPlan extends QueryPlan[SparkPlan] 
with Logging with Serializ
       final def execute(): RDD[InternalRow] = {
         RDDOperationScope.withScope(sparkContext, nodeName, false, true) {
           prepare()
    -      doExecute()
    +
    +      if (sqlContext.conf.wholeStageEnabled && supportCodeGen
    --- End diff --
    
    It might be nice to actually make this a first class concept in the 
planner.  Perhaps a phase that collects valid nodes and replaces them with an 
explicit operator called `WholeStageCodeGen` that holds all the operators that 
are getting.  I'm not sure how hard that would be, but it would make debugging 
this a lot easier if it was visible from explain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to