Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10703#discussion_r49675326
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala 
---
    @@ -56,3 +57,9 @@ private[sql] abstract class BucketedOutputWriterFactory 
extends OutputWriterFact
           context: TaskAttemptContext): OutputWriter =
         throw new UnsupportedOperationException("use bucket version")
     }
    +
    +private[sql] object BucketingUtils {
    --- End diff --
    
    +1 
    
    Structurally it is better for bucketing to be a user of a general hash 
expression, rather than the other way around.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to