Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/10663#discussion_r49734713
--- Diff:
core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala ---
@@ -30,19 +29,7 @@ private[ui] class ExecutorThreadDumpPage(parent:
ExecutorsTab) extends WebUIPage
private val sc = parent.sc
def render(request: HttpServletRequest): Seq[Node] = {
- val executorId = Option(request.getParameter("executorId")).map {
- executorId =>
- // Due to YARN-2844, "<driver>" in the url will be encoded to
"%25253Cdriver%25253E" when
- // running in yarn-cluster mode.
`request.getParameter("executorId")` will return
- // "%253Cdriver%253E". Therefore we need to decode it until we get
the real id.
- var id = executorId
- var decodedId = URLDecoder.decode(id, "UTF-8")
- while (id != decodedId) {
- id = decodedId
- decodedId = URLDecoder.decode(id, "UTF-8")
- }
- id
- }.getOrElse {
+ val executorId = Option(request.getParameter("executorId")).getOrElse {
--- End diff --
`decodeURLParameter` is not invoked.
We should say like as follows right?
```
Option(...).map { executorId =>
UIUtils.decodeURLParameter(executorId)
}.getOrElse {
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
