Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10747#discussion_r49763739
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -336,12 +336,7 @@ class Dataset[T] private[sql](
def mapPartitions[U : Encoder](func: Iterator[T] => Iterator[U]):
Dataset[U] = {
new Dataset[U](
sqlContext,
- MapPartitions[T, U](
- func,
- resolvedTEncoder,
- encoderFor[U],
- encoderFor[U].schema.toAttributes,
- logicalPlan))
+ MapPartitions[T, U](func, logicalPlan))
--- End diff --
This is different from the previous one, we only pass the type parameter
`T` to `MapPartitions` and build a new encoder there which is unresolved, while
before this PR we pass a `resolvedTEncoder`. Do we break the life cycle of
encoder in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
