Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10593#discussion_r49765061
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java
 ---
    @@ -154,6 +184,45 @@ public float getProgress() throws IOException, 
InterruptedException {
         return (float) rowsReturned / totalRowCount;
       }
     
    +  /**
    +   * Returns the ColumnarBatch object that will be used for all rows 
returned by this reader.
    +   * This object is reused. Calling this enables the vectorized reader. It 
is not valid to
    +   * call nextKeyValue/nextBatch before calling this.
    +   */
    +  public ColumnarBatch resultBatch() {
    +    return resultBatch(DEFAULT_OFFHEAP);
    +  }
    +  public ColumnarBatch resultBatch(boolean offHeap) {
    +    if (columnarBatch == null) {
    +      columnarBatch = ColumnarBatch.allocate(sparkSchema, offHeap);
    +    }
    +    return columnarBatch;
    +  }
    +
    +  /**
    +   * Advances to the next batch of rows. Returns false if there are no 
more.
    +   */
    +  public boolean nextBatch() throws IOException {
    +    assert(columnarBatch != null);
    +    columnarBatch.reset();
    +    if (rowsReturned >= totalRowCount) return false;
    +    checkEndOfRowGroup();
    +
    +    int num = (int)Math.min((long) columnarBatch.capacity(), totalRowCount 
- rowsReturned);
    +    for (int i = 0; i < columnReaders.length; ++i) {
    +      switch (columnReaders[i].descriptor.getType()) {
    +        case INT32:
    --- End diff --
    
    No. I plan to support binary as nested types which involves more 
complicated changes in the ColumnarBatch classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to