Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10745#discussion_r49776959
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSQLParser.scala ---
@@ -31,7 +31,12 @@ import org.apache.spark.sql.types.StringType
*
* @param fallback A function that parses an input string to a logical plan
*/
-class SparkSQLParser(fallback: String => LogicalPlan) extends
AbstractSparkSQLParser {
+class SparkSQLParser(fallback: => ParserDialect) extends
AbstractSparkSQLParser {
--- End diff --
OK in that case we should have a comment here explaining the choice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
