Github user nongli commented on a diff in the pull request:
https://github.com/apache/spark/pull/10705#discussion_r49796899
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -43,6 +43,7 @@ import org.apache.spark.rpc.RpcEnv
import org.apache.spark.serializer.{Serializer, SerializerInstance}
import org.apache.spark.shuffle.ShuffleManager
import org.apache.spark.util._
+import org.apache.spark.util.collection.ReferenceCounter
--- End diff --
Can you add a comment in this class that explains the ref counting
mechanism? It can be a shorter version of the commit message.
Specifically:
What are the invariants? (explain get()) Need to call release. What does
it mean if it is 0?
I slightly prefer pin count over ref count (the block manager has a
reference but it is unpinned)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
