Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10762#discussion_r49813672
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
    @@ -179,10 +180,15 @@ object SqlParser extends AbstractSparkSQLParser with 
DataTypeParser {
         )
     
       protected lazy val joinedRelation: Parser[LogicalPlan] =
    -    relationFactor ~ rep1(joinType.? ~ (JOIN ~> relationFactor) ~ 
joinConditions.?) ^^ {
    +    relationFactor ~
    +      rep1(NATURAL.? ~ joinType.? ~ (JOIN ~> relationFactor) ~ 
joinConditions.?) ^^ {
           case r1 ~ joins =>
    -        joins.foldLeft(r1) { case (lhs, jt ~ rhs ~ cond) =>
    -          Join(lhs, rhs, joinType = jt.getOrElse(Inner), cond)
    +        joins.foldLeft(r1) { case (lhs, n ~ jt ~ rhs ~ cond) =>
    +          if (n.isDefined) {
    +            NaturalJoin(lhs, rhs, joinType = jt.getOrElse(Inner), cond)
    --- End diff --
    
    can't we just create a new join type rather than creating a whole new 
logical operator?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to