Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10745#discussion_r49903342
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
---
@@ -135,7 +135,7 @@ case class HyperLogLogPlusPlus(
override def dataType: DataType = LongType
- override def inputTypes: Seq[AbstractDataType] = Seq(AnyDataType)
+ override def inputTypes: Seq[AbstractDataType] = Seq(AnyDataType,
DoubleType)
--- End diff --
`inputTypes` is used to check input types, however, `HyperLogLogPlusPlus`
only have one input, see
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala#L132.
So we don't need to give 2 type constraints here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
