Github user RussellSpitzer commented on the pull request:
https://github.com/apache/spark/pull/10655#issuecomment-172145152
I personally think the ambiguous `PUSHED_FILTERS` is more confusing. When
we see a predicate there we have no idea whether or not it is a valid filter
for the source at all. Like in the C* case this could contain clauses which
have no way have being actually pushed down to the source.
In my mind their are 3 Categories of predicates
* Those which cannot be pushed to the source at all
* Those which can be pushed to the source but may have false positives
* Those which can be pushed to the source and filter completely
Currently we can only tell whether or not a predicate is in on of the first
two categories or if it is in the third. This leaves is awkwardly stating that
the source has had a predicate `Pushed` to it even when that is impossible. I
like just stating the Third category because thats the only thing we truly can
be sure of given the current code. It would be better if the underlying source
was able to qualify all filters into the above categories.
So to me it is more confusing to say something is `Pushed` when it
technically can't be than to say something is not `Pushed` when it might be.
But ymmv
If you want to just go with Asterisks thats fine with me too just wanted to
make my argument :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
