GitHub user BenFradet opened a pull request:
https://github.com/apache/spark/pull/10787
[SPARK-12858] [CORE] Remove duplicated code in metrics
I noticed there is some duplicated code in the sinks regarding the poll
period.
Also, parts of the metrics.properties template were unclear.
This PR aims to fix both issues.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/BenFradet/spark SPARK-12858
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10787.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10787
----
commit 83d03d58aa5198af47a3bd716b8b2e23889461cd
Author: BenFradet <[email protected]>
Date: 2016-01-15T18:31:11Z
HasPollingPeriod trait
commit e2fd74016706a36326d50bd62b5dc0ee5c35a28b
Author: BenFradet <[email protected]>
Date: 2016-01-15T21:40:57Z
made the different sinks mix-in HasPollingPeriod
commit 1ebb657f6857ea7d5064677b378bd4eb223112bf
Author: BenFradet <[email protected]>
Date: 2016-01-15T21:41:34Z
rmd checkMinimalPollingPeriod from MetricsSystem
commit ca0cefd8549e10670ec0643d054bb8fd704d9bbb
Author: BenFradet <[email protected]>
Date: 2016-01-15T21:43:40Z
mvd the "checkMinimalPollingPeriod" method to the companion object of trait
HasPollingPeriod
commit 47ed641b25e30e9e00823b27ae55b5aa174244ae
Author: BenFradet <[email protected]>
Date: 2016-01-15T22:30:31Z
renamed a few variables
commit 02cf327d68db3b05b7fff516f78aad05e399f6fb
Author: BenFradet <[email protected]>
Date: 2016-01-15T22:41:55Z
added "reporter" to the Sink trait
commit a5f33e480bedb3eecbfb6e8403dae4cb433b890e
Author: BenFradet <[email protected]>
Date: 2016-01-15T22:42:28Z
overrode "reporter" for the sinks
commit dc2c766299df76b36446a45b80a4fc4c6e7f3941
Author: BenFradet <[email protected]>
Date: 2016-01-16T14:47:39Z
rmd "reporter" from the Sink trait
commit 12f1147d60441854749f6cc5dca20920c73c5d63
Author: BenFradet <[email protected]>
Date: 2016-01-16T15:10:40Z
corrected a few things in the metrics.properties.template
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
