Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10782#discussion_r49939469
  
    --- Diff: network/yarn/pom.xml ---
    @@ -86,6 +88,15 @@
                   </excludes>
                 </filter>
               </filters>
    +          <relocations>
    --- End diff --
    
    I'm now thinking all the dependencies should be relocated, with the 
exception of the jni leveldb stuff —not the thing you can shade; not the 
thing you can isolate in a classloader hierarchy instead.
    
    What I can do there is add a profile, `leveldb-provided` which excludes 
leveldb in this situation. That's important as leveldb does creep onto the 
classpath from elsewhere —and while the version in Hadoop currently matches 
that in this JAR, there's no guarantee of that continuing to hold.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to