Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/1428#issuecomment-49211681
That is exactly the argument I made when the folding logic was added. :) I
suggested that we add `deterministic` instead and then have a rule that folds
things that are `deterministic` and have no `references`. `deterministic` I
would argue is something fundamental about the expression itself, unlike these
optimizations we are making.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
