Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/10796#discussion_r49951468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -651,12 +651,11 @@ object HiveTypeCoercion {
case e if !e.childrenResolved => e
// Find tightest common type for If, if the true value and false
value have different types.
case i @ If(pred, left, right) if left.dataType != right.dataType =>
- findTightestCommonTypeToString(left.dataType, right.dataType).map
{ widestType =>
+ findWiderTypeForTwo(left.dataType, right.dataType).map {
widestType =>
--- End diff --
This failed on the HiveCompatibilitySuite.udf_if test on the following
query: ```SELECT IF(FALSE, 1, 1.1)```. It would not cast the trueCase to a
decimal. ```CASE WHEN... ELSE``` did work and I used similar code for ```if````.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
