Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10788#discussion_r49962157
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -322,10 +343,12 @@ class LogisticRegression @Since("1.2.0") (
new BreezeOWLQN[Int, BDV[Double]]($(maxIter), 10, regParamL1Fun,
$(tol))
}
- val initialCoefficientsWithIntercept =
- Vectors.zeros(if ($(fitIntercept)) numFeatures + 1 else numFeatures)
+ val numFeaturesWithIntercept = if ($(fitIntercept)) numFeatures + 1
else numFeatures
+ val userSuppliedCoefficients = validateWeights(optInitialCoefficients,
numFeaturesWithIntercept)
--- End diff --
let's handle it through setInitialModel, and have another PR to make it
public. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
