Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10776#discussion_r49967340
  
    --- Diff: core/src/main/scala/org/apache/spark/CacheManager.scala ---
    @@ -163,11 +156,10 @@ private[spark] class CacheManager(blockManager: 
BlockManager) extends Logging {
            * single partition. Instead, we unroll the values cautiously, 
potentially aborting and
            * dropping the partition to disk if applicable.
            */
    -      blockManager.memoryStore.unrollSafely(key, values, updatedBlocks) 
match {
    +      blockManager.memoryStore.unrollSafely(key, values) match {
             case Left(arr) =>
               // We have successfully unrolled the entire partition, so cache 
it in memory
    -          updatedBlocks ++=
    --- End diff --
    
    This update has been pushed further down into the BlockManager code. See 
the changes to `doPut()`. The same holds for the `putIterator()` call above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to