Github user ygcao commented on the pull request:
https://github.com/apache/spark/pull/10152#issuecomment-172468729
ouch, we finally decided to make backward incompatible changes for
synonyms~~. That caused test case failure.
I adjusted the expected value according our new logic: always return
normalized similarity value for findSyonyms function
Also added defense code for potential divide by zero accordingly referring
to @srowen 's hot fix of another similar situation.
I have 90% confidence that these change is enough for passing tests.
The reason why I can't be 100%, is that spark sql can't compile and
run_tests script is not working in my local env. I hacked out the expected
value, but I verified it against before and after change.
FYI: the compiling issue on master branch about Spark SQL, not relevant to
our changes, but is a blocker somebody should look into.
[error]
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala:311:
reference to Rollup is ambiguous;
[error] it is imported twice in the same scope by
[error] import org.apache.spark.sql.catalyst.plans.logical._
[error] and import org.apache.spark.sql.catalyst.expressions._
[error] Seq(Rollup(children.map(nodeToExpr))),
[error] ^
[error]
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystQl.scala:319:
reference to Cube is ambiguous;
[error] it is imported twice in the same scope by
[error] import org.apache.spark.sql.catalyst.plans.logical._
[error] and import org.apache.spark.sql.catalyst.expressions._
[error] Seq(Cube(children.map(nodeToExpr))),
[error] ^
[error]
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:191:
reference to Rollup is ambiguous;
[error] it is imported twice in the same scope by
[error] import org.apache.spark.sql.catalyst.plans.logical._
[error] and import org.apache.spark.sql.catalyst.expressions._
[error] def bitmasks(r: Rollup): Seq[Int] = {
[error] ^
[error]
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:204:
reference to Cube is ambiguous;
[error] it is imported twice in the same scope by
[error] import org.apache.spark.sql.catalyst.plans.logical._
[error] and import org.apache.spark.sql.catalyst.expressions._
[error] def bitmasks(c: Cube): Seq[Int] = {
[error] ^
[error]
spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:210:
reference to Cube is ambiguous;
[error] it is imported twice in the same scope by
[error] import org.apache.spark.sql.catalyst.plans.logical._
[error] and import org.apache.spark.sql.catalyst.expressions._
[error] case Aggregate(Seq(c @ Cube(groupByExprs)),
aggregateExpressions, child) =>
[error]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
