Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10798#discussion_r50050542
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -1053,12 +1053,13 @@ private[spark] class Client(
     
     }
     
    -object Client extends Logging {
    +private[deploy] object Client extends Logging {
     
       def main(argStrings: Array[String]) {
         if (!sys.props.contains("SPARK_SUBMIT")) {
    -      logWarning("WARNING: This client is deprecated and will be removed 
in a " +
    -        "future version of Spark. Use ./bin/spark-submit with \"--master 
yarn\"")
    +      logError("Error: Client main class should not be called. " +
    +        "Use ./bin/spark-submit with \"--master yarn\"")
    +      throw new SparkException("Client main class should not be called")
    --- End diff --
    
    why not just throw SparkException with the full error message?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to