Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10815#discussion_r50054765
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -118,18 +141,37 @@ class TaskMetrics extends Serializable {
_inputMetrics = inputMetrics
}
+ private var _outputMetrics: Option[OutputMetrics] = None
+
/**
- * If this task writes data externally (e.g. to a distributed
filesystem), metrics on how much
- * data was written are stored here.
+ * Metrics related to writing data externally (e.g. to a distributed
filesystem),
+ * defined only in tasks with output.
*/
- var outputMetrics: Option[OutputMetrics] = None
+ def outputMetrics: Option[OutputMetrics] = _outputMetrics
+
+ @deprecated("setting OutputMetrics is for internal use only", "2.0.0")
--- End diff --
Do you know whether there's any third-party code that calls this? Wondering
if we can just drop it. Also, AFAIK this would only be for
source-compatibility: code which directly set `outputMetrics` will be
binary-incompatible with this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
