Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/5852#discussion_r50124423
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -256,9 +266,13 @@ final class ShuffleBlockFetcherIterator(
// Add the remote requests into our queue in a random order
fetchRequests ++= Utils.randomize(remoteRequests)
+ assert ((0 == reqsInFlight) == (0 == bytesInFlight),
+ "reqsInFlight = " + reqsInFlight + ", bytesInFlight = " +
bytesInFlight)
// Send out initial requests for blocks, up to our maxBytesInFlight
while (fetchRequests.nonEmpty &&
- (bytesInFlight == 0 || bytesInFlight + fetchRequests.front.size <=
maxBytesInFlight)) {
+ (bytesInFlight == 0 ||
--- End diff --
it would be nice to make another function to do this set of checks since
its the same as below
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
