Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10814#discussion_r50171308
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala
---
@@ -154,4 +154,17 @@ class SubexpressionEliminationSuite extends
SparkFunSuite {
equivalence.addExpr(sum)
assert(equivalence.getAllEquivalentExprs.isEmpty)
}
+
+ test("Children of CodegenFallback") {
--- End diff --
We does not have a non-leaf expression that use CodegenFallback, except
imperative aggregate function, it ends up we can't easily have a end-end test
without generated aggregation with imperative function support (WIP).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
