Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/10779#discussion_r50174005
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/scheduler/StreamingListenerBus.scala
---
@@ -51,12 +62,15 @@ private[spark] class StreamingListenerBus
}
}
- override def onDropEvent(event: StreamingListenerEvent): Unit = {
- if (logDroppedEvent.compareAndSet(false, true)) {
- // Only log the following message once to avoid duplicated annoying
logs.
- logError("Dropping StreamingListenerEvent because no remaining room
in event queue. " +
- "This likely means one of the StreamingListeners is too slow and
cannot keep up with the " +
- "rate at which events are being started by the scheduler.")
- }
+ /**
+ * Wrap StreamingListenerEvent as SparkListenerEvent so that it can be
posted to Spark listener
--- End diff --
nit: Wrapper for StreamingListenerEvent as SparkListenerEvent...
Wraps --> verb, user for methods that does something. Class should be a
noun.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
