Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/10744#discussion_r50182291
--- Diff:
external/zeromq/src/main/scala/org/apache/spark/streaming/zeromq/ZeroMQUtils.scala
---
@@ -128,6 +221,42 @@ object ZeroMQUtils {
implicitly[ClassTag[AnyRef]].asInstanceOf[ClassTag[T]]
val fn =
(x: Seq[ByteString]) =>
bytesToObjects.call(x.map(_.toArray).toArray).iterator().asScala
- createStream[T](jssc.ssc, publisherUrl, subscribe, fn)
+ createStream[T](
+ jssc.ssc,
+ publisherUrl,
+ subscribe,
+ fn)
+ }
+
+ /**
+ * Create an input stream that receives messages pushed by a zeromq
publisher.
--- End diff --
Here too please reduce the number of createStream versions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
