Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/10480#discussion_r50198797
--- Diff: core/src/main/scala/org/apache/spark/api/r/SerDe.scala ---
@@ -355,6 +355,13 @@ private[spark] object SerDe {
writeInt(dos, v.length)
v.foreach(elem => writeObject(dos, elem))
+ // Handle Properties
--- End diff --
Yeah it still feels awkward to just do this specially for the Properties
object.
@felixcheung Do you have an idea what part of the code would move to scala
if we want to do it on the scala side ? Typically we do deal with such
conversions on the scala side, so thats the main reason I'm asking. Is it just
the `varargsToJProperties` function ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
