Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10837#discussion_r50212640
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala
---
@@ -253,6 +256,9 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
extends Product {
/**
* Returns a copy of this node where `rule` has been recursively applied
to it and all of its
* children (pre-order). When `rule` does not apply to a given node it
is left unchanged.
+ *
+ * Note that this function does not recurse into the children of a node
that is being replaced.
--- End diff --
Do we need to explain this? This is so obvious that we can't recurse into
the children of a node that is being replaced in a top-down transformation, or
there is no way to define how the result will be.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
