Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1447#discussion_r15042032
--- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
---
@@ -216,17 +216,17 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
def reducePartition(iter: Iterator[(K, V)]): Iterator[JHashMap[K, V]]
= {
val map = new JHashMap[K, V]
- iter.foreach { case (k, v) =>
- val old = map.get(k)
- map.put(k, if (old == null) v else func(old, v))
+ iter.foreach { pair =>
+ val old = map.get(pair._1)
--- End diff --
Removing the call to _1 isn't hugely helpful IMO; accessor methods get
inlined very fast. However, pattern matching adds a whole bunch of potential
throw sites and branches and things like that, and we've noticed problems in
the past.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
