Github user NarineK commented on the pull request:
https://github.com/apache/spark/pull/9667#issuecomment-173381317
I've pushed all the suggestions and changes.
@jkbradley I have a concern with respect to: weight: Vector and
lossHistory: Array[Double] which is originally being returned by runLBFGS
method. According to my discussions with breeze and the scala documentation
Iterators have memory benefits(mentioned also in book:
https://books.google.com/books?id=fvkYCwAAQBAJ&pg=PA151&lpg=PA151&dq=iterator+vs+array+scala+memory&source=bl&ots=7m17wT5A7G&sig=AHKbYbV-Hg80sjzaNkBv_amcsw8&hl=en&sa=X&ved=0ahUKEwji2o2YsbnKAhVIbR4KHdFbBkYQ6AEITTAH#v=onepage&q=iterator%20vs%20array%20scala%20memory&f=false)
.
When we iterate and push some of the values into array and vector, it seems
that we might hit some issues ? I'm not very sure, just trying to understand.
What do you think ?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
