Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10845#discussion_r50497168
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -462,6 +462,32 @@ object HiveTypeCoercion {
val resultType = widerDecimalType(p1, s1, p2, s2)
b.makeCopy(Array(Cast(e1, resultType), Cast(e2, resultType)))
+ // Strength reduction for comparisons between an integral column
and a decimal literal:
+ // 1. int_col > decimal_literal => int_col > floor(decimal_literal)
+ // 2. int_col >= decimal_literal => int_col >=
ceil(decimal_literal)
+ // 3. int_col < decimal_literal => int_col < ceil(decimal_literal)
+ // 4. int_col <= decimal_literal => int_col <=
floor(decimal_literal)
+ // 5. decimal_literal > int_col => ceil(decimal_literal) > int_col
+ // 6. decimal_literal >= int_col => floor(decimal_literal) >=
int_col
+ // 7. decimal_literal < int_col => floor(decimal_literal) < int_col
+ // 8. decimal_literal <= int_col => ceil(decimal_literal) <=
int_col
+ case GreaterThan(i @ IntegerType(), Literal(value: Decimal, _:
DecimalType)) =>
--- End diff --
this should apply for any integral type, not just integer. Also can you
make this function shorter by breaking it into two functions? It is pretty long
now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
