Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10762#discussion_r50497869
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -164,11 +164,42 @@ case class Join(
left.output.map(_.withNullability(true)) ++ right.output
case FullOuter =>
left.output.map(_.withNullability(true)) ++
right.output.map(_.withNullability(true))
+ case NaturalJoin(jt) =>
+ outerProjectList(jt).map(_.toAttribute)
case _ =>
left.output ++ right.output
}
}
+ def outerProjectList(jt: JoinType): Seq[NamedExpression] = {
--- End diff --
there are a lot of duplicated code here with output (although they are
slightly different). can we rewrite them to make it simpler?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
