Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10835#discussion_r50642789
--- Diff: core/src/main/scala/org/apache/spark/executor/TaskMetrics.scala
---
@@ -39,68 +37,144 @@ import org.apache.spark.util.Utils
*
* So, when adding new fields, take into consideration that the whole
object can be serialized for
* shipping off at any time to consumers of the SparkListener interface.
+ *
+ * @param initialAccums the initial set of accumulators that this
[[TaskMetrics]] depends on.
+ * Each accumulator in this initial set must be
uniquely named and marked
+ * as internal. Additional accumulators registered
later need not satisfy
--- End diff --
You could add a `require` in the constructor which checks that each of
these metrics is actually internal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
