Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10835#discussion_r50645443
  
    --- Diff: core/src/main/scala/org/apache/spark/Accumulator.scala ---
    @@ -156,5 +165,23 @@ object AccumulatorParam {
         def zero(initialValue: Float): Float = 0f
       }
     
    -  // TODO: Add AccumulatorParams for other types, e.g. lists and strings
    +  // Note: when merging values, this param just adopts the newer value. 
This is used only
    --- End diff --
    
    This is a little confusing and I maybe wonder whether it'd be worth having 
a class named something like `LatestValueAccumulableParam[T]` to handle this in 
a generic way, but for now this is okay.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to