Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10835#discussion_r50742068
  
    --- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
    @@ -42,6 +42,8 @@ private[spark] abstract class SparkFunSuite extends 
FunSuite with Logging {
           test()
         } finally {
           logInfo(s"\n\n===== FINISHED $shortSuiteName: '$testName' =====\n")
    +      // Avoid leaking map entries in tests that use accumulators without 
SparkContext
    +      Accumulators.clear()
    --- End diff --
    
    We want to isolate state across each test. Otherwise we might get an 
accumulator that's registered in a previous test and that's confusing if it 
fails.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to