Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/10820#discussion_r50784640
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnVector.java
---
@@ -42,13 +58,77 @@ public static ColumnVector allocate(int capacity,
DataType type, MemoryMode mode
}
}
+ /**
+ * Holder object to return an array. This object is intended to be
reused. Callers should
+ * copy the data out if it needs to be stored.
+ * TODO: consider adding all the get APIs that are 0 indexed. This would
just be a convenience
+ * wrapper. Measure this for common usage patterns and see if there is
an overhead.
+ * int getInt(index) {
+ * return data.getInt(index + offset);
+ * }
+ */
+ public static final class Array {
--- End diff --
Can we make this extend ArrayData? similar to what we have done for Row.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
