Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10835#discussion_r50789284
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -1648,7 +1648,7 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
test("external sorting updates peak execution memory") {
AccumulatorSuite.verifyPeakExecutionMemorySet(sparkContext, "external
sort") {
- sortTest()
+ sql("SELECT * FROM testData2 ORDER BY a ASC, b ASC").collect()
--- End diff --
This is actually a stricter test. What `verifyPeakExecutionMemorySet` does
is assert that the peak memory is incremented in the code block. If we do many
things in the code block then it's not guaranteed that a single sort like this
one actually increments the peak memory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
