Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/10835#discussion_r50805368
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Task.scala ---
@@ -141,6 +136,18 @@ private[spark] abstract class Task[T](
def executorDeserializeTime: Long = _executorDeserializeTime
/**
+ * Collect the latest values of accumulators used in this task. If the
task failed,
+ * filter out the accumulators whose values should not be included on
failures.
+ */
+ def collectAccumulatorUpdates(taskFailed: Boolean = false):
Seq[AccumulableInfo] = {
+ if (context != null) {
--- End diff --
none currently. I just didn't want to throw a random NPE if this is somehow
called before `run`. I think either doing an explicit assert or this check
makes sense, because before calling `run` we have no accumulator updates and so
it makes sense to return an empty `Seq`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
