Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10835#discussion_r50810761
--- Diff: core/src/main/scala/org/apache/spark/util/JsonProtocol.scala ---
@@ -787,10 +851,13 @@ private[spark] object JsonProtocol {
val className = (json \ "Class Name").extract[String]
val description = (json \ "Description").extract[String]
val stackTrace = stackTraceFromJson(json \ "Stack Trace")
- val fullStackTrace = Utils.jsonOption(json \ "Full Stack Trace").
- map(_.extract[String]).orNull
- val metrics = Utils.jsonOption(json \
"Metrics").map(taskMetricsFromJson)
- ExceptionFailure(className, description, stackTrace,
fullStackTrace, metrics, None)
+ val fullStackTrace = (json \ "Full Stack
Trace").extractOpt[String].orNull
+ // Fallback on getting accumulator updates from TaskMetrics, which
was logged in Spark 1.x
+ // TODO: add a test
--- End diff --
I guess the easy way to write a test would be to literally copy the old
JSON from the old test case and just inline it in a single deserialization test
method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
