Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/10648#discussion_r50884354
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
@@ -82,72 +65,37 @@ private[history] class HistoryPage(parent:
HistoryServer) extends WebUIPage("")
<h4>
Showing {actualFirst + 1}-{last + 1} of {allAppsSize}
{if (requestedIncomplete) "(Incomplete applications)"}
- <span style="float: right">
- {
- if (actualPage > 1) {
- <a href={makePageLink(actualPage - 1,
requestedIncomplete)}>< </a>
- <a href={makePageLink(1, requestedIncomplete)}>1</a>
- }
- }
- {if (actualPage - plusOrMinus > secondPageFromLeft) "
... "}
- {leftSideIndices}
- {actualPage}
- {rightSideIndices}
- {if (actualPage + plusOrMinus < secondPageFromRight) "
... "}
- {
- if (actualPage < pageCount) {
- <a href={makePageLink(pageCount,
requestedIncomplete)}>{pageCount}</a>
- <a href={makePageLink(actualPage + 1,
requestedIncomplete)}> ></a>
- }
- }
- </span>
</h4> ++
- appTable
+ <div id="history-summary"></div>
} else if (requestedIncomplete) {
<h4>No incomplete applications found!</h4>
} else {
<h4>No completed applications found!</h4> ++
- <p>Did you specify the correct logging directory?
- Please verify your setting of <span
style="font-style:italic">
- spark.history.fs.logDirectory</span> and whether you have
the permissions to
- access it.<br /> It is also possible that your application
did not run to
- completion or did not stop the SparkContext.
- </p>
+ <p>Did you specify the correct logging directory?
+ Please verify your setting of <span
style="font-style:italic">
+ spark.history.fs.logDirectory</span> and whether you
have the permissions to
+ access it.<br /> It is also possible that your
application did not run to
+ completion or did not stop the SparkContext.
+ </p>
}
- }
- <a href={makePageLink(actualPage, !requestedIncomplete)}>
- {
+ }
+
+ <a href={makePageLink(actualPage, !requestedIncomplete)}>
+ {
if (requestedIncomplete) {
"Back to completed applications"
} else {
"Show incomplete applications"
}
- }
- </a>
- </div>
+ }
+ </a>
+ </div>
+ <script src={UIUtils.prependBaseUri("/static/historypage.js")}>
</script>
+
</div>
UIUtils.basicSparkPage(content, "History Server")
}
- private val appHeader = Seq(
- "App ID",
- "App Name",
- "Started",
- "Completed",
- "Duration",
- "Spark User",
- "Last Updated")
-
- private val appWithAttemptHeader = Seq(
- "App ID",
- "App Name",
- "Attempt ID",
- "Started",
- "Completed",
- "Duration",
- "Spark User",
- "Last Updated")
-
private def rangeIndices(
--- End diff --
if you remove the above you can remove this function too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
