Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10568#discussion_r50906675
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/NettyRpcEnv.scala 
---
    @@ -182,7 +182,11 @@ private[netty] class NettyRpcEnv(
         val remoteAddr = message.receiver.address
         if (remoteAddr == address) {
           // Message to a local RPC endpoint.
    -      dispatcher.postOneWayMessage(message)
    +      try {
    +        dispatcher.postOneWayMessage(message)
    +      } catch {
    +        case NonFatal(e) => logWarning(e.getMessage, e)
    --- End diff --
    
    Since #10881 is already handling the one case where we don't care about the 
exception, can you remove this `try..catch` and just let any other exceptions 
propagate up the stack?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to