Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10911#discussion_r50907571
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketchImpl.java
---
@@ -348,4 +374,30 @@ public static CountMinSketchImpl readFrom(InputStream
in) throws IOException {
return new CountMinSketchImpl(depth, width, totalCount, hashA, table);
}
+
+ @Override
+ public void writeExternal(ObjectOutput out) throws IOException {
+ try (ByteArrayOutputStream bos = new ByteArrayOutputStream()) {
+ this.writeTo(bos);
+ byte[] bytes = bos.toByteArray();
+ out.writeObject(bytes);
--- End diff --
bloom filters can get pretty big when cardinality is high (e.g. 500MB).
It's best if we can avoid the extra copying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
