Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10881#discussion_r50908005
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/netty/Dispatcher.scala 
---
    @@ -106,7 +106,7 @@ private[netty] class Dispatcher(nettyEnv: NettyRpcEnv) 
extends Logging {
         val iter = endpoints.keySet().iterator()
         while (iter.hasNext) {
           val name = iter.next
    -      postMessage(name, message, (e) => logWarning(s"Message $message 
dropped.", e))
    +      postMessage(name, message, (e) => logWarning(s"Message $message 
dropped."))
    --- End diff --
    
    Could you update the message as `s"Message $message dropped. 
${e.getMessage}"`? It's worth to add the exception message here since there are 
two types of exceptions. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to