Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10270#issuecomment-175306040
@jkbradley probably is the best to check with, I'm not sure how important
the pydoc generation would be for the models. The approach often taken in the
scala code is to make a shared Params class that both the model and the
estimator inherit which seems like it might offer some nice tradeoffs (we don't
have to duplicate the list of params everywhere, custom params are able to be
copied, and doc gen works) but it does add some extra bit of code per-model so
if we don't care about the pydoc that much it might not be a good solution
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
