Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10911#discussion_r50926598
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/CountMinSketchImpl.java
---
@@ -325,27 +321,43 @@ public void writeTo(OutputStream out) throws
IOException {
}
public static CountMinSketchImpl readFrom(InputStream in) throws
IOException {
+ CountMinSketchImpl sketch = new CountMinSketchImpl();
+ sketch.readFrom0(in);
+ return sketch;
--- End diff --
Hm, I prefer not, because then we'll have to make the no-arg constructor
package private instead of private.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
