Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/10912#discussion_r50947072
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
---
@@ -445,4 +445,9 @@ class JDBCSuite extends SparkFunSuite with
BeforeAndAfter {
assert(agg.getCatalystType(1, "", 1, null) == Some(StringType))
}
+ test("OracleDialect type mapping") {
+ val oracleDialect = JdbcDialects.get("jdbc:oracle://127.0.0.1/db")
+
assert(oracleDialect.getJDBCType(StringType).map(_.databaseTypeDefinition).get
== "VARCHAR2(255)")
+ }
--- End diff --
I am not sure this test works. Let me be clear. We need to add a docker
integration test like `MySQLIntegrationSuite`. Since spark 1.4 branch does not
have the testing infrastructure. I think the the right way to do it is for your
new PR (using the same JIRA id in the title) created for master, you add the
test. Then, for this PR, we just keep the fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
