Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/10931#issuecomment-175773465
Oh, forgot one thing:
> Test suite passed.
Note that the change that caused SPARK-11615 *also* passed the test suite.
That happens for two reasons:
- by default, tests are run with sbt, which doesn't do shading
- even if you trigger a maven build, tests are run before shading, with the
original jars in the classpath, so you wouldn't catch that anyway.
In any case, you should add `[test-maven]` to your PR title to trigger a
maven build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
