Github user tribbloid commented on a diff in the pull request:
https://github.com/apache/spark/pull/8785#discussion_r51038017
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -75,6 +78,16 @@ private[sql] object JDBCRelation {
}
ans.toArray
}
+
+ def getEffectiveProperties(
+ connectionProperties: Properties,
+ extraOptions: scala.collection.Map[String, String] = Map()):
Properties = {
+ val props = new Properties()
+ props.putAll(extraOptions.asJava)
+ // connectionProperties should override settings in extraOptions
+ props.putAll(connectionProperties)
--- End diff --
yes they can be preserved by the deep copy, but unfortunately any changes
on parent properties AFTER the deep copy won't be preserved in returned value.
I expect callers of this function to use its returned value transiently.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
