Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10723#discussion_r51074937
  
    --- Diff: 
sql/catalyst/src/main/antlr3/org/apache/spark/sql/catalyst/parser/SparkSqlLexer.g
 ---
    @@ -465,7 +467,7 @@ Identifier
     fragment    
     QuotedIdentifier 
         :
    -    '`'  ( '``' | ~('`') )* '`' { setText(getText().substring(1, 
getText().length() -1 ).replaceAll("``", "`")); }
    +    '`'  ( '``' | ~('`') )* '`' { setText(getText().replaceAll("``", 
"`")); }
    --- End diff --
    
    `QuotedIdentifier` originally strips first and last backticks. So we don't 
know if an identifier is quoted or not. In create table ddl commands, you can 
specify a column name with quoted string to use special characters. If we strip 
backticks early at `QuotedIdentifier`, then we can not have these column names 
passed in. So I change it to not strip the first and last backticks and use 
`cleanIdentifier` to get rid of the backticks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to