Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10944#discussion_r51166689
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala 
---
    @@ -42,10 +44,16 @@ trait CodegenSupport extends SparkPlan {
       private var parent: CodegenSupport = null
     
       /**
    -    * Returns an input RDD of InternalRow and Java source code to process 
them.
    +    * Returns the RDD of InternalRow which generates the input rows.
         */
    -  def produce(ctx: CodegenContext, parent: CodegenSupport): 
(RDD[InternalRow], String) = {
    +  def upstream(): RDD[InternalRow]
    +
    +  /**
    +    * Returns Java source code to process the rows from upstream.
    +    */
    +  def produce(ctx: CodegenContext, parent: CodegenSupport): String = {
         this.parent = parent
    +    ctx.freshNamePrefix = nodeName
    --- End diff --
    
    Do we have a notion of node id? This is not going to help when we have many 
joins in one pipeline. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to