Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10762#discussion_r51182725
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -1159,6 +1161,41 @@ class Analyzer(
           }
         }
       }
    +
    +  /**
    +   * Removes natural joins by calculating output columns based on output 
from two sides,
    +   * Then apply a Project on a normal Join to eliminate natural join.
    +   */
    +  object ResolveNaturalJoin extends Rule[LogicalPlan] {
    +    override def apply(plan: LogicalPlan): LogicalPlan = plan 
resolveOperators {
    +      // Should not skip unresolved nodes because natural join is always 
unresolved.
    +      case j @ Join(left, right, NaturalJoin(joinType), condition) if 
j.partlyResolved =>
    +        val joinNames = 
left.output.map(_.name).intersect(right.output.map(_.name))
    --- End diff --
    
    you need to add more inline comment for this function to explain what's 
going on


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to